Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pretty-format): expose ConvertAnsi plugin #12308

Merged
merged 3 commits into from Feb 6, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 6, 2022

Summary

This is the only builtin plugin that's not enabled by default, and having an official way of retrieving it (at least from JS config) seems like a good idea.

E.g. https://github.com/jest-community/jest-watch-typeahead/blob/b08ae652f0c2c35f179d5f5578385fc85973dba4/package.json#L84 can stop reaching into build, which is not supported.

Test plan

Green CI

@codecov-commenter
Copy link

Codecov Report

Merging #12308 (1efd137) into main (94a6752) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12308   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         329      329           
  Lines       17346    17346           
  Branches     5074     5074           
=======================================
  Hits        11666    11666           
  Misses       5648     5648           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a6752...1efd137. Read the comment docs.

@SimenB SimenB merged commit 5a95898 into jestjs:main Feb 6, 2022
@SimenB SimenB deleted the expose-convert-ansi branch February 6, 2022 09:23
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants