fix(expect): move typings of .not, .rejects and .resolves modifiers outside of Matchers interface
#12346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Feb 9, 2022
| not: Omit<AsymmetricMatchers, 'any' | 'anything'>; | ||
| }; | ||
|
|
||
| export interface AsymmetricMatchers { |
There was a problem hiding this comment.
These were not exported before. I think it might be good idea to allow extending these too.
Codecov Report
@@ Coverage Diff @@
## main #12346 +/- ##
==========================================
- Coverage 66.97% 66.93% -0.04%
==========================================
Files 329 329
Lines 17335 17344 +9
Branches 5061 5061
==========================================
Hits 11610 11610
- Misses 5693 5702 +9
Partials 32 32
Continue to review full report at Codecov.
|
SimenB
approved these changes
Feb 9, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current
expecttypings allow to write expectations like this:expect(1).not.not.resolves.rejects.not.rejects.toBe(2). Looks funny. That’s because .not,.rejectsand.resolveslives insideMatchersinterface.I looked at
@types/jest. Their types work correctly, but it was hard to read them. My version is perhaps less perfect, but I think it is easier to read.Test plan
Type tests which will fail on
mainare added. All should pass in CI.