Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove defensive code marked for removal #12353

Merged
merged 4 commits into from Feb 10, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 10, 2022

Summary

For Jest 28

Test plan

Green CI

@codecov-commenter
Copy link

Codecov Report

Merging #12353 (c006a30) into main (2953433) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12353      +/-   ##
==========================================
+ Coverage   66.93%   66.95%   +0.01%     
==========================================
  Files         329      329              
  Lines       17344    17340       -4     
  Branches     5061     5057       -4     
==========================================
  Hits        11610    11610              
+ Misses       5702     5698       -4     
  Partials       32       32              
Impacted Files Coverage Δ
packages/jest-config/src/index.ts 20.73% <ø> (ø)
packages/jest-resolve/src/utils.ts 27.27% <ø> (+2.94%) ⬆️
packages/jest-runner/src/index.ts 64.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2953433...c006a30. Read the comment docs.

@SimenB SimenB merged commit a651b65 into jestjs:main Feb 10, 2022
@SimenB SimenB deleted the remove-defensive-code branch February 10, 2022 10:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants