feat: stop shipping jsdom by default
#12354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
remove-jsdom-default
branch
from
d98eec6
to
7472227
Compare
SimenB
force-pushed
the
remove-jsdom-default
branch
from
7472227
to
b48a162
Compare
Codecov Report
@@ Coverage Diff @@
## main #12354 +/- ##
==========================================
- Coverage 66.94% 66.92% -0.02%
==========================================
Files 329 329
Lines 17345 17350 +5
Branches 5059 5060 +1
==========================================
Hits 11612 11612
- Misses 5701 5706 +5
Partials 32 32
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As announced in the Jest v27 blog post, we'll stop shipping jsdom and jasmine by default. This PR removes JSDOM.
Test plan
Green CI