Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate jest-serializer #12391

Merged
merged 1 commit into from Feb 15, 2022
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 15, 2022

Summary

Since #8455 (https://github.com/facebook/jest/pull/8455/files#r314608524) this package has just been a thin facade over v8 APIs, so it serves no real purpose.

I'll keep the source code until the Jest 28 stable release, at which point I'll deprecate that version (so people stuck on 27 or older do not see the warning. There's nothing wrong with 27, it's just unneeded) and delete the source.

Test plan

Green CI

@mrazauskas
Copy link
Contributor

Good move.

Wondering, if perhaps it is time to retire jest-repl? I was trying to play with it some time ago and couldn’t get how it works. No docs around. Looking at PR which added it seemed like this was interesting experiment, but is it still needed or useful? Of course, does not hurt to have it. Just thinking out loud (;

@SimenB
Copy link
Member Author

SimenB commented Feb 15, 2022

Yeah, good call. Let's do the same thing (releasing a v28, then deprecate it)

@SimenB SimenB merged commit c557359 into jestjs:main Feb 15, 2022
@SimenB SimenB deleted the deprecated-jest-serializer branch February 15, 2022 12:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants