New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed describe and it/test to take in functions again #12484
Allowed describe and it/test to take in functions again #12484
Conversation
Nice! CI seems happy 馃檪 Can you add type tests as well? https://github.com/facebook/jest/blob/c65bb4521597fb1ad65dacd778a26e04684b2872/packages/jest-types/__typetests__/globals.test.ts
Runtime support is already test by the test you added in #5154, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog entry as well? 馃檪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thank you for the pointers @SimenB! 馃檶 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Partially replicates DefinitelyTyped/DefinitelyTyped#23102 by allowing
describe
to take in a number or function.Fixes #12483.
Test plan
I can verify TypeScript thinks these things are valid:
I couldn't figure out where the right place to test this at runtime is, though. Could someone help please? 馃檪Actually, there are a bunch of compiler issues - I'll work on those.