fix: correct message when no tests found and findRelatedTests passed
#12487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Feb 24, 2022
| @@ -17,7 +17,10 @@ describe('No tests are found', () => { | |||
| '/non/existing/path/', | |||
| ]); | |||
|
|
|||
| expect(stdout).toMatch('No tests found'); | |||
There was a problem hiding this comment.
I've expanded these assertions to include the exit code and the line about passWithNoTests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12478.
I originally changedfindRelatedTeststo fail unlesspassWithNoTestswas provided, but backed it out. Now I just fix the message to reflect the exit code.I'm not sure about #5127 (review), though. At least for the mentionedI do think it makes sense to fail now.findRelatedTestsTest plan
Tests tweaked