Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Farm work results leakage by clearing callback reference #12497

Merged
merged 4 commits into from Feb 25, 2022

Conversation

IIIEII
Copy link
Contributor

@IIIEII IIIEII commented Feb 25, 2022

Summary

Fixes #11633
Jest-worker Farm had leakage with execution results, added code to prevent it

Test plan

Updated leak-integration.test.ts jest-worker test to reproduce problem that is gone after my changes.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thank you! could you add a changelog entry as well?

@IIIEII
Copy link
Contributor Author

IIIEII commented Feb 25, 2022

wonderful, thank you! could you add a changelog entry as well?

@SimenB SimenB merged commit fc3d034 into jestjs:main Feb 25, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-worker farm memory leak
3 participants