chore: refactor tests + clean up unused code in SearchSource

[brandon-leapyear]

Summary

These areas of the code were brought to my attention as part of #12519, but are good improvements independent of any other feature work.

Test plan

See the commit messages for the reasoning of each refactoring/clean up

[SimenB]

thanks! lovely cutting and DRYing

[brandon-leapyear]

Had to revert the path.normalize removal, also took the time to break up the "Refactor SearchSource tests" commit. Feel free to squash when merging; I just like breaking up commits for my personal workflow + to make commit-by-commit reviewing possible

[SimenB]

Yeah, we squash on merge, but lots of commit within the PR is nice 👍

There are some failing tests, btw

[brandon-leapyear]

Ok, hopefully I've fixed the tests. FYI locally, the import/order linter is saying

e2e/native-esm/__tests__/native-esm.test.js
  13:1  error  `node:dns` import should occur after import of `url`  import/order

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

but CI fails when making this change. Not sure why the discrepancy between local + CI

[SimenB]

@brandon-leapyear yeah, unfortunately that rule behaves differently between node version (only considered "core" when it exists in the runtime.). Using Node 16 (maybe 14?) locally should make eslint agree with current formatting 🙂

[brandon-leapyear]

@SimenB Not sure what that CI failure is. The test passes locally for me, and it doesn't seem related to my changes

[SimenB]

yeah: #12521 (comment) 🙁

[SimenB]

Thanks for this cleanup though, looks great!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.