chore: run prettier on everything #12653
Conversation
|
Hi @fisker! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
e2e/coverage-handlebars/greet.hbs
Outdated
| {{else}} | ||
| evening | ||
| {{/if}} | ||
| {{name}}!</p> |
There was a problem hiding this comment.
Looks like a bug in Prettier, it removed the final new line.
There was a problem hiding this comment.
this is the failing test as well btw, changed the coverage report. Can add an ignore comment so we can land this PR?
|
Thanks! Huh, eslint is supposed to run on all ts and js (with prettier plugin). seemingly not working correctly... |
Didn't notice that, excluded |
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -19,5 +19,5 @@ module.exports = { | |||
| }, | |||
| ], | |||
| '@babel/preset-typescript', | |||
| ] | |||
| ], | |||
There was a problem hiding this comment.
Not the biggest diff in the end 😀
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Test plan