Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not report unref-ed subprocesses as open handles #12705

Merged
merged 2 commits into from Apr 21, 2022

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 21, 2022

Summary

I came over nodejs/node#42731 (review), which has a very good point about the type of resources we should check hasRef on.

Test plan

Test added

} else {
isActive = resource.hasRef.bind(resource);
}
// Handle that supports hasRef
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore whitespace

@SimenB SimenB merged commit 4beda2d into jestjs:main Apr 21, 2022
@SimenB SimenB deleted the unreffed-subprocess branch April 21, 2022 06:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants