Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest-resolve): expose PackageFilter, PathFilter and PackageJSON types #12712

Merged
merged 2 commits into from Apr 22, 2022

Conversation

mrazauskas
Copy link
Contributor

Following up #12707

Summary

@types/resolve got fixed, so it is possible to get rid of a todo comment.

I think it is useful to expose PackageFilter, PathFilter and PackageJSON types as well. For instance to allow this:

const packageFilter: PackageFilter //...
const pathFilter: PathFilter //...

PackageJSON type comes from this suggestion: DefinitelyTyped/DefinitelyTyped#59990 (comment)

Test plan

Type tests added.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 3c6f14b into jestjs:main Apr 22, 2022
@mrazauskas mrazauskas deleted the feat-resolver-more-types branch April 22, 2022 10:42
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants