Lock source-map-support verion to 0.5.13 #12720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Apr 23, 2022
F3n67u
changed the title
F3n67u
force-pushed
the
chore/source-map-support
branch
from
22212f7
to
584be79
Compare
F3n67u
force-pushed
the
chore/source-map-support
branch
from
584be79
to
cfdd94a
Compare
updated! thanks for the review. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
source-map-support 0.5.14 introduces a "breaking change" which will cause the original function name gets lost in the Jest error stack in the jest scenario. see this issue #10633.
I think we should let source-map-support stay to 0.5.13 explicitly on
package.jsonbecause^0.5.6could resolve to a version above 0.5.13. this will cause a problem on the user side.I am working on Yarn dedupe check on ci. When I ran
yarn dedupeon jest codebase,source-map-supportwill resolve to the latest version0.5.21which break a lot of snapshot test because the "breaking change" source-map-support 0.5.14 introduces. see this run for detail: https://github.com/facebook/jest/pull/12717/checks?check_run_id=6138255708Test plan
Green CI.