fix(jest-circus): improve test.concurrent

[dmitri-gb]

Summary

This change is a minor rewrite of the implementation of test.concurrent in jest-circus. It moves the test function invocation to a later point in time, so that it would be possible to apply proper test filtering (focused tests, testNamePattern, describe.skip). Previously such filtering was not applied to concurrent tests and they were always invoked.

Additionally, concurrent tests are now invoked after the global (top-level) beforeAll hooks. Previously this was not the case.

Finally, beforeEach and afterEach hooks are no longer invoked for concurrent tests at all. Previously both hooks were invoked after (or during) the test.

Test plan

Some existing tests for concurrent have been modified to verify the changes described above.

An illustrative example:

beforeAll(() => {
  console.log('running beforeAll');
});

it.concurrent('test A', async () => {
  console.log('message from test A');
});

it.concurrent('test B', async () => {
  console.log('message from test B');
});

jest -t "test B"

Before:

  console.log
    message from test A

      at Object.log [as fn] (main.test.js:8:11)

  console.log                                                                                                                                                                                                                                         
    message from test B                                                                                                                                                                                                                               

      at Object.log [as fn] (main.test.js:12:11)

  console.log
    running beforeAll

      at Object.log (main.test.js:4:11)

 PASS  ./main.test.js
  √ test B                                                                                                                                                                                                                                            
  ○ skipped test A

After:

  console.log
    running beforeAll

      at Object.log (main.test.js:4:11)

  console.log                                                                                                                                                                                                                                         
    message from test B                                                                                                                                                                                                                               

      at Object.log [as fn] (main.test.js:12:11)

 PASS  ./main.test.js
  √ test B (1 ms)
  ○ skipped test A

Fixes #4281
Fixes #10790
Fixes #11248
Fixes #12068
Fixes #12588

[SimenB]

oh, wow, this is fantastic!

could you fix the linting errors and add a changelog entry?

[dmitri-gb]

@SimenB done!

[SimenB]

Thanks!

[SimenB]

https://github.com/facebook/jest/releases/tag/v28.0.1

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.