fix(expect-utils): Fix deep equality of ImmutableJS Lists #12763
Conversation
|
Hi @romellem! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Yes please, a dev dep is perfectly fine! (we already have one in |
|
Seems this broke some other tests we have, actually |
|
Thanks, I'll add the new tests and look at the errors on the existing tests a little later on. |
Some of their internal properties may not match, but they should be considered equal.
|
Didn't read the logic carefully enough for Sets, it isn't checking order (which makes sense). So instead we don't do the |
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de>
romellem
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #12752
Test plan
I could add a test case for
iterableEquality, but I'd need to introduceimmutableas a dev dependency. Let me know if you'd like to. Otherwise, this relies on the fact that immutable'sListimplements a similar API to nativeSetobjects, importantly,.has().