Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct await-ed inline snapshot indentation #12986

Merged

Conversation

robinpokorny
Copy link
Contributor

Summary

When testing asynchronous code using .resolves/.rejects it is mandatory to await the expect. When combined with an inline snapshot, the snapshot is not indented correctly. It is aligned to the expect not the await.

Example

it('is a test', async () => {
  await expect(Promise.resolve({ a: 'a' })).resolves.toMatchInlineSnapshot();
});

Currently becomes:

it('is a test', async () => {
  await expect(Promise.resolve({ a: 'a' })).resolves.toMatchInlineSnapshot(`
          Object {
            "a": "a",
          }
        `);
});

After the change:

it('is a test', async () => {
  await expect(Promise.resolve({ a: 'a' })).resolves.toMatchInlineSnapshot(`
    Object {
      "a": "a",
    }
  `);
});

Test plan

See the unit test in packages/jest-snapshot/src/tests/InlineSnapshots.test.ts:633

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

packages/jest-snapshot/src/InlineSnapshots.ts Outdated Show resolved Hide resolved
@SimenB SimenB changed the title Correct await inline snapshot indentation Correct await-ed inline snapshot indentation Jul 5, 2022
@SimenB SimenB merged commit fe33f3d into jestjs:main Jul 5, 2022
@robinpokorny robinpokorny deleted the correct-await-inline-snapshot-indentation branch July 5, 2022 12:32
@SimenB
Copy link
Member

SimenB commented Jul 13, 2022

https://github.com/facebook/jest/releases/tag/v28.1.3

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants