Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestScheduler dispatch upon exec error #13203

Merged
merged 10 commits into from Sep 4, 2022

Conversation

connectdotz
Copy link
Contributor

Summary

Modified TestScheduler.scheduleTests to capture runtime execError in aggregatedResults and notify reporters via onRunComplete.

fix #13187

Test plan

new tests have been added, all tests should pass.

change autoRun setting to avoid the long startup full-test run.
@connectdotz
Copy link
Contributor Author

Hi, I checked in a non-code related to change so I can also see if the earlier test check failure is just a hiccup. Sure enough, the previously failed check has passed. However, a new check failed, but it is not related to the code change in this PR. So I think the code is ready for review, @SimenB please feel free to take a look when you have the cycle. Thanks.

@connectdotz connectdotz changed the title fix TestScheduler fail to dispatch onRunComplete upon exec error fix TestScheduler dispatch upon exec error Sep 2, 2022
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

packages/jest-core/src/TestScheduler.ts Outdated Show resolved Hide resolved
packages/jest-core/src/TestScheduler.ts Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit dbda13f into jestjs:main Sep 4, 2022
@connectdotz connectdotz deleted the reporter-notification branch September 6, 2022 02:44
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: reporter onRunComplete not triggered when jest runner crashed in watch mode
3 participants