fix(jest-runtime): Guard '_isMockFunction' access with 'in' #14188
+34
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue in
jest-runtime
when attempting to reset global mocks. Whenjest
is running inside of VS Code to test a VS Code extension, it attempts to read_isMockFunction
from aProxy
that happens to throw in itsget
handler when you unconditionally read a property that does not exist. Prefixing this condition with a test forin
avoids evaluating theget
hook.NOTE: While this does resolve this specific case, it's still possible a global could be a
Proxy
that even throws onin
, though that would generally be a bad practice. It would be much safer to replace_isMockFunction
entirely with aWeakSet
that does not interact with aProxy
at all, but that is a far more comprehensive change than I'm willing to commit to at this point.Test plan
I've tested this locally through the use of a custom
JestEnvironment
, such as this one:I've added something similar to the above as a test in this PR.
Fixes #14095