Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-each] Refactor logic #6345

Merged
merged 4 commits into from
May 29, 2018
Merged

Conversation

mattphillips
Copy link
Contributor

Summary

This PR refactors the jest-each library to use the shared bind logic integral to Jest's core.

This way we have only one implementation and the changes propagate to all instances of the each logic

Test plan

Tests should still pass

@thymikee
Copy link
Collaborator

Nice cleanup!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiiice

@codecov-io
Copy link

Codecov Report

Merging #6345 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6345      +/-   ##
==========================================
- Coverage   63.89%   63.63%   -0.27%     
==========================================
  Files         228      226       -2     
  Lines        8705     8648      -57     
  Branches        4        4              
==========================================
- Hits         5562     5503      -59     
- Misses       3142     3144       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-each/src/index.js 77.77% <100%> (+7.18%) ⬆️
packages/jest-each/src/bind.js 100% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13dd2f...689378b. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants