Fix yarn test on windows

[hron]

Summary

Some of the tests fail on Windows when they are run with yarn test. Several fails are due to concurrency problem, one is about relying on LF as EOF in one of the json file.

Test plan

Before

After

[SimenB]

can we fix the test instead?

[hron]

To do this I guess I need to replace CRLF with LF in runtime here (https://github.com/facebook/jest/blob/master/packages/jest-config/src/__tests__/normalize.test.js#L936-L950):

    jest.doMock('/node_modules/react-native/jest-preset.json', () =>
      require.requireActual('./jest-preset.json'),
    );

I'm not sure how to do this properly and it doesn't seem like a good solution to me. Here is the failing output for the details:

Click to update snapshot for 'throws when preset is invalid' test

Error: expect(value).toMatchSnapshot()

Received value does not match stored snapshot "preset throws when preset is invalid 1".

- Snapshot
+ Received

  "<red><bold><bold>● <bold>Validation Error</>:</>
  <red></>
  <red>  Preset <bold>react-native</> is invalid:</>
- <red>  Unexpected token } in JSON at position 104</>
+ <red>  Unexpected token } in JSON at position 110</>
  <red></>
  <red>  <bold>Configuration Documentation:</></>
  <red>  https://facebook.github.io/jest/docs/configuration.html</>
  <red></>"
    at Object.test (E:\src\jest\packages\jest-config\src\__tests__\normalize.test.js:949:8)
    at Object.asyncFn (E:\src\jest\packages\jest-jasmine2\build\jasmine_async.js:108:37)
    at resolve (E:\src\jest\packages\jest-jasmine2\build\queue_runner.js:56:12)
    at new Promise (<anonymous>)
    at mapper (E:\src\jest\packages\jest-jasmine2\build\queue_runner.js:43:19)
    at promise.then (E:\src\jest\packages\jest-jasmine2\build\queue_runner.js:87:41)
    at <anonymous>

[hron]

@SimenB what about using .toThrowError here instead of trying to match a snapshot that depends on CRLF vs LF?

[SimenB]

That sounds good to me! Mind removing the obsolete snapshot and rebasing?

[hron]

The obsolete snapshot has been removed. I hope CI will pass now.

[codecov-io]

Codecov Report

Merging #6534 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6534   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8931     8931           
  Branches        4        4           
=======================================
  Hits         5692     5692           
  Misses       3238     3238           
  Partials        1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e0a1b...50f99a7. Read the comment docs.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.