Fix enter to interrupt #6601
Merged
Fix enter to interrupt #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah! Sneaky. I love how an attempt to make something more readable introduced the bug. We need e2e tests on this... I'll see if I can find the time to look into it this summer |
SimenB
approved these changes
Jul 2, 2018
rogeliog
approved these changes
Jul 2, 2018
This was referenced Jul 4, 2018
schalkneethling
pushed a commit
to mdn/interactive-examples
that referenced
this pull request
Jul 6, 2018
This Pull Request renovates the package group "jest monorepo". - [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` - [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` # Release Notes <details> <summary>facebook/jest</summary> ### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#​2330) [Compare Source](jestjs/jest@v23.2.0...v23.3.0) ##### Features - `[jest-cli]` Allow watch plugin to be configured ([#​6603](`jestjs/jest#6603)) - `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#​6380](`jestjs/jest#6380)) ##### Fixes - `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#​6523](`jestjs/jest#6523)) - `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#​6579](`jestjs/jest#6579)) - `[jest-cli]` Fix enter to interrupt watch mode ([#​6601](`jestjs/jest#6601)) ##### Chore & Maintenance - `[website]` Switch domain to https://jestjs.io ([#​6549](`jestjs/jest#6549)) - `[tests]` Improve stability of `yarn test` on Windows ([#​6534](`jestjs/jest#6534)) - `[*]` Transpile object shorthand into Node 4 compatible syntax ([#​6582](`jestjs/jest#6582)) - `[*]` Update all legacy links to jestjs.io ([#​6622](`jestjs/jest#6622)) - `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#​6623](`jestjs/jest#6623)) - `[website]` Only test/deploy website if relevant files are changed ([#​6626](`jestjs/jest#6626)) - `[docs]` Describe behavior of `resetModules` option when set to `false` ([#​6641](`jestjs/jest#6641)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Aug 1, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where hitting keys in watch mode would not interrupt
Fixes #6598