Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all legacy url to jestjs.io #6622

Merged
merged 4 commits into from
Jul 4, 2018
Merged

Update all legacy url to jestjs.io #6622

merged 4 commits into from
Jul 4, 2018

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Jul 4, 2018 •
edited

Summary

Since the move to jestjs.io and removal of /jest/ baseUrl, we should update all the url accordingly as well

  1. Fix Website > 404 error on "Mocking Library" link on index #6620
  2. replace all the legacy /jest/ linking to /
  3. Update https://facebook.github.io/jest/ to https://jestjs.io/

Test plan

cd website
yarn start

Url is now working

@thymikee thymikee mentioned this pull request Jul 4, 2018
Closed
@thymikee
Copy link
Collaborator

thymikee commented Jul 4, 2018 •
edited

Can we also update all references to "https://facebook.github.io/jest/" in blog posts etc?
Also, lint is unhappy.

@endiliey
Copy link
Contributor Author

endiliey commented Jul 4, 2018

@thymikee sure. Will https://jestjs.io/ be ok ? The linting should be easy to fix 😂

By the way it seems that jestjs.io doesn't force visitor to be on https, is this intentional ?

@endiliey endiliey requested a review from orta as a code owner July 4, 2018 18:04
@endiliey endiliey changed the title Replace /jest/ with / to migrate legacy url Update all legacy url to jestjs.io Jul 4, 2018
@codecov-io
Copy link

codecov-io commented Jul 4, 2018 •
edited

Codecov Report

Merging #6622 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6622   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8935     8935           
  Branches        4        4           
=======================================
  Hits         5695     5695           
  Misses       3239     3239           
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-editor-support/src/Settings.js 71.05% <ø> (ø) ⬆️
...ages/jest-cli/src/lib/init/generate_config_file.js 100% <ø> (ø) ⬆️
packages/jest-runtime/src/index.js 72.53% <ø> (ø) ⬆️
packages/jest-runtime/src/helpers.js 50% <ø> (ø) ⬆️
packages/jest-config/src/utils.js 77.19% <ø> (ø) ⬆️
packages/jest-validate/src/validate_cli_options.js 62.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3844b55...5ee3493. Read the comment docs.

@thymikee
Copy link
Collaborator

thymikee commented Jul 4, 2018

By the way it seems that jestjs.io doesn't force visitor to be on https, is this intentional ?

Nope, but we'll get to it ;)

@thymikee
Copy link
Collaborator

thymikee commented Jul 4, 2018

Looks like "http://facebook.github.io/jest" are still not changed. Mind updating to https://jestjs.io too?

@rickhanlonii
Copy link
Member

@thymikee @endiliey updated 👍

@thymikee
Copy link
Collaborator

thymikee commented Jul 4, 2018

Thanks @rickhanlonii. Feel free to merge when ready :)

@rickhanlonii rickhanlonii merged commit c6512ad into jestjs:master Jul 4, 2018
@SimenB
Copy link
Member

SimenB commented Jul 4, 2018

Fix the description while we're at it?

image

@endiliey endiliey deleted the index branch July 5, 2018 02:28
schalkneethling pushed a commit to mdn/interactive-examples that referenced this pull request Jul 6, 2018
@renovate
chore(deps): update jest monorepo to v23.3.0 (#1012)
e1adf0d 
This Pull Request renovates the package group "jest monorepo".


-   [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`
-   [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0`

# Release Notes
<details>
<summary>facebook/jest</summary>

### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#&#8203;2330)
[Compare Source](jestjs/jest@v23.2.0...v23.3.0)
##### Features

- `[jest-cli]` Allow watch plugin to be configured ([#&#8203;6603](`jestjs/jest#6603))
- `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#&#8203;6380](`jestjs/jest#6380))
##### Fixes

- `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#&#8203;6523](`jestjs/jest#6523))
- `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#&#8203;6579](`jestjs/jest#6579))
- `[jest-cli]` Fix enter to interrupt watch mode ([#&#8203;6601](`jestjs/jest#6601))
##### Chore & Maintenance

- `[website]` Switch domain to https://jestjs.io ([#&#8203;6549](`jestjs/jest#6549))
- `[tests]` Improve stability of `yarn test` on Windows ([#&#8203;6534](`jestjs/jest#6534))
- `[*]` Transpile object shorthand into Node 4 compatible syntax ([#&#8203;6582](`jestjs/jest#6582))
- `[*]` Update all legacy links to jestjs.io ([#&#8203;6622](`jestjs/jest#6622))
- `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#&#8203;6623](`jestjs/jest#6623))
- `[website]` Only test/deploy website if relevant files are changed ([#&#8203;6626](`jestjs/jest#6626))
- `[docs]` Describe behavior of `resetModules` option when set to `false` ([#&#8203;6641](`jestjs/jest#6641))

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
This was referenced Jul 7, 2018
Closed
Merged
Closed
This was referenced Aug 1, 2018
Open
Open
@dependencies dependencies bot mentioned this pull request Nov 1, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website > 404 error on "Mocking Library" link on index
6 participants
@endiliey @thymikee @codecov-io @rickhanlonii @SimenB @facebook-github-bot