fix: testMatch not working with negations #6648
Conversation
|
@thymikee checked. Nope, it didnt do anything |
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
- Coverage 63.62% 63.62% -0.01%
==========================================
Files 235 235
Lines 9018 9017 -1
Branches 3 4 +1
==========================================
- Hits 5738 5737 -1
Misses 3279 3279
Partials 1 1
Continue to review full report at Codecov.
|
|
As reported #6668 I've added @retyui can you check if this fixes your use case? EDIT: Reverted, as it failed badly. Will leave it for someone else to investigate 😅 |
thymikee
force-pushed
the
fix/test-match
branch
from
ad57534
to
24abf79
Compare
* upstream/master: (122 commits) fix: don't report promises as open handles (jestjs#6716) support serializing `DocumentFragment` (jestjs#6705) Allow test titles to include array index (jestjs#6414) fix `toContain` suggest to contain equal message (jestjs#6810) fix: testMatch not working with negations (jestjs#6648) Add test cases for jestjs#6744 (jestjs#6772) print stack trace on calls to process.exit (jestjs#6714) Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735) Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773) [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807) Update CHANGELOG.md (jestjs#6799) fix changelog entry that is not in 23.4.2 (jestjs#6796) Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736) Update testURL default value from about:blank to localhost (jestjs#6792) fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776) Fix retryTimes and add e2e regression test (jestjs#6762) Release v23.4.2 Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754) chore(packages/babel-jest) readme (jestjs#6746) docs: noted --coverage aliased by --collectCoverage (jestjs#6741) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
When searching for test matches, we used
micromatchin a bit convoluted way, which didn't take advantage of its regular API.Fixes #6440,
possibly #6546 but didn't test it (@aldarund could you check if this diff fixes your issue?).Test plan
Extended one test that fails without this patch.