Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't report promises as open handles #6716

Merged
merged 4 commits into from
Aug 8, 2018
Merged

fix: don't report promises as open handles #6716

merged 4 commits into from
Aug 8, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 19, 2018 •
edited

Summary

Promises do not keep the node process open, so there's no reason for us to keep track of them

Fixes #6639

Test plan

Test added

@SimenB SimenB mentioned this pull request Jul 19, 2018
Merged
@codecov-io
Copy link

codecov-io commented Jul 19, 2018 •
edited

Codecov Report

Merging #6716 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6716      +/-   ##
==========================================
- Coverage   63.56%   63.54%   -0.02%     
==========================================
  Files         235      235              
  Lines        9026     9028       +2     
  Branches        3        4       +1     
==========================================
  Hits         5737     5737              
- Misses       3288     3290       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/collectHandles.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a16c5d...4cd9c76. Read the comment docs.

@SimenB SimenB mentioned this pull request Jul 21, 2018
Closed
@ncrmro ncrmro mentioned this pull request Jul 26, 2018
Closed
@ermik
Copy link

ermik commented Jul 30, 2018

Could we possibly release these tasty changes in the coming week?

@andynhi
Copy link

andynhi commented Aug 2, 2018

until this fixed is merge is everyone else using --forceExit as a temporary fix?

@ccruz2886
Copy link

ccruz2886 commented Aug 3, 2018 •
edited

@andynhi I'm using --forceExit too, still seeing the warning message of the open handles... is there an ETA of these changes?

@jimzhan
Copy link

jimzhan commented Aug 3, 2018

Any updates?

@SimenB
Copy link
Member Author

SimenB commented Aug 4, 2018 •
edited

This has nothing to do with actually helping the process exit, it's just removal of a false positive from detectOpenHandles

@medfreeman medfreeman mentioned this pull request Aug 7, 2018
Open
@alex-page alex-page mentioned this pull request Aug 8, 2018
Closed
@thymikee thymikee mentioned this pull request Aug 8, 2018
Merged
@thymikee thymikee merged commit 0591f22 into jestjs:master Aug 8, 2018
thymikee added a commit to rhysawilliams2010/jest that referenced this pull request Aug 8, 2018
@thymikee
Merge remote-tracking branch 'upstream/master' into pr/6334
f671f8e 
* upstream/master: (122 commits)
  fix: don't report promises as open handles (jestjs#6716)
  support serializing `DocumentFragment` (jestjs#6705)
  Allow test titles to include array index (jestjs#6414)
  fix `toContain` suggest to contain equal message (jestjs#6810)
  fix: testMatch not working with negations (jestjs#6648)
  Add test cases for jestjs#6744 (jestjs#6772)
  print stack trace on calls to process.exit (jestjs#6714)
  Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735)
  Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773)
  [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807)
  Update CHANGELOG.md (jestjs#6799)
  fix changelog entry that is not in 23.4.2 (jestjs#6796)
  Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736)
  Update testURL default value from about:blank to localhost (jestjs#6792)
  fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776)
  Fix retryTimes and add e2e regression test (jestjs#6762)
  Release v23.4.2
  Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754)
  chore(packages/babel-jest) readme (jestjs#6746)
  docs: noted --coverage aliased by --collectCoverage (jestjs#6741)
  ...
@SimenB SimenB deleted the exclude-promises-open-handle branch August 9, 2018 11:54
This was referenced Aug 10, 2018
Merged
Merged
Open
Merged
Open
Open
Closed
Closed
@jure
Copy link

jure commented Aug 31, 2018

Just for reference, why-is-node-running recently implemented this as well: mafintosh/why-is-node-running#37

For some reason --detectOpenHandles did not find my open handles, and why-is-node-running did. Maybe someone knows immediately why that would be (the unreported things was https://github.com/brianc/node-postgres/blob/master/lib/connection.js#L51 through knex, bluebird and tarn.Pool), but otherwise I'd be happy to explore where the difference comes from.

@SimenB
Copy link
Member Author

SimenB commented Aug 31, 2018

@jure help would be greatly appreciated!

This was referenced Oct 1, 2018
Open
Open
@dependencies dependencies bot mentioned this pull request Nov 1, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using lodash causes "open handles" warnings
9 participants
@SimenB @codecov-io @ermik @andynhi @ccruz2886 @jimzhan @jure @thymikee @facebook-github-bot