Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toContain suggest to contain equal message #6810

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

Gregjarvez
Copy link
Contributor

fixes #6808

Summary

toContain provides a useful "suggest to contain equal" message. This is however not formatted properly.

This PR add a line break to enhance readability.

Test plan

Only updated snapshots.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #6810 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6810      +/-   ##
==========================================
+ Coverage   63.56%   63.63%   +0.07%     
==========================================
  Files         235      235              
  Lines        9026     9017       -9     
  Branches        3        4       +1     
==========================================
+ Hits         5737     5738       +1     
+ Misses       3288     3278      -10     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-snapshot/src/State.js 0% <0%> (ø) ⬆️
packages/jest-runner/src/run_test.js 3.44% <0%> (+0.46%) ⬆️
packages/jest-cli/src/SearchSource.js 45.13% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a16c5d...2afbf5b. Read the comment docs.

@thymikee
Copy link
Collaborator

thymikee commented Aug 7, 2018

Mind adding a changelog? :)

@Gregjarvez Gregjarvez force-pushed the fix-toContain-matchers-output branch from 870ebcb to 16aacad Compare August 7, 2018 10:01
@thymikee
Copy link
Collaborator

thymikee commented Aug 7, 2018

Fix lint and we can merge this :)

@Gregjarvez
Copy link
Contributor Author

Gregjarvez commented Aug 8, 2018

in a bit !!.

@Gregjarvez Gregjarvez force-pushed the fix-toContain-matchers-output branch from 16aacad to 2afbf5b Compare August 8, 2018 12:56
@thymikee thymikee merged commit 9f07036 into jestjs:master Aug 8, 2018
@Gregjarvez Gregjarvez deleted the fix-toContain-matchers-output branch August 8, 2018 14:24
thymikee added a commit to rhysawilliams2010/jest that referenced this pull request Aug 8, 2018
* upstream/master: (122 commits)
  fix: don't report promises as open handles (jestjs#6716)
  support serializing `DocumentFragment` (jestjs#6705)
  Allow test titles to include array index (jestjs#6414)
  fix `toContain` suggest to contain equal message (jestjs#6810)
  fix: testMatch not working with negations (jestjs#6648)
  Add test cases for jestjs#6744 (jestjs#6772)
  print stack trace on calls to process.exit (jestjs#6714)
  Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735)
  Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773)
  [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807)
  Update CHANGELOG.md (jestjs#6799)
  fix changelog entry that is not in 23.4.2 (jestjs#6796)
  Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736)
  Update testURL default value from about:blank to localhost (jestjs#6792)
  fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776)
  Fix retryTimes and add e2e regression test (jestjs#6762)
  Release v23.4.2
  Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754)
  chore(packages/babel-jest) readme (jestjs#6746)
  docs: noted --coverage aliased by --collectCoverage (jestjs#6741)
  ...
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toContain gives unhelpful error message when value being checked is an object
4 participants