Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-resolve - only resolve realpath once in try-catch #6925

Merged
merged 2 commits into from
Aug 30, 2018
Merged

jest-resolve - only resolve realpath once in try-catch #6925

merged 2 commits into from
Aug 30, 2018

Conversation

asapach
Copy link
Contributor

@asapach asapach commented Aug 30, 2018

Summary

Fixes #6880. As discussed in #6906, wrap realpath call in try-catch and invoke only once, since it should be enough to resolve the canonical path.

Test plan

Updated the existing tests to make sure nothing breaks.

@arcanis, @SimenB, @thymikee, @palmerj3

@SimenB SimenB merged commit 065a0b2 into jestjs:master Aug 30, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-resolve fails on network drives and RAM-drives on Windows
5 participants