diff-sequences: Double-check number of differences in tests #6953
+62
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6953 +/- ##
=======================================
Coverage 66.97% 66.97%
=======================================
Files 250 250
Lines 10379 10379
Branches 4 3 -1
=======================================
Hits 6951 6951
Misses 3427 3427
Partials 1 1Continue to review full report at Codecov.
|
This was referenced Sep 10, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To increase confidence in such a complex algorithm, call a simpler baseline algorithm to compute the number of differences between sequences independently in many of the tests.
Test plan
The new criterion passes for the existing tests which use it.
By the way, it finally hit me that history of changes to files in repo might be better fuzz inputs to diff algorithm than anything I could generate. So offline, I compared number of differences from complex to simpler algorithms for 10306 files in the 2000 commits going back in history from Jest 23.5.0 Ha ha, image files were fuzzier than I wanted, so filtered to js, json, md, and snap files.