[jest-each]: Add empty string/array validation check #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This works for test.each``('bla', () => {});as well? |
mattphillips
changed the title
|
And test.each`
a | b | expected
`('bla', () => {});? |
Codecov Report
@@ Coverage Diff @@
## master #7249 +/- ##
==========================================
+ Coverage 66.55% 66.57% +0.01%
==========================================
Files 237 237
Lines 9317 9321 +4
Branches 3 3
==========================================
+ Hits 6201 6205 +4
Misses 3115 3115
Partials 1 1
Continue to review full report at Codecov.
|
thymikee
approved these changes
Oct 23, 2018
packages/jest-each/src/bind.js
Outdated
| tableArg[0].trim() === '' | ||
| ) { | ||
| const error = new ErrorWithStack( | ||
| 'Error: `.each` called with an empty tagged template string of table data.\n', |
There was a problem hiding this comment.
I think it's called "tagged template literal"
SimenB
approved these changes
Oct 30, 2018
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation: @SimenB's #7100 (comment)
Test plan