Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid re-run of tests in watch mode #7347

Merged
merged 6 commits into from May 3, 2020
Merged

Fix invalid re-run of tests in watch mode #7347

merged 6 commits into from May 3, 2020

Conversation

rubennorte
Copy link
Contributor

Summary

Fixes #7124. Watch mode shouldn't trigger a new test run when only the access time of the file has been modified.

Test plan

Added e2e tests.

@rubennorte rubennorte force-pushed the do-not-trigger-tests-on-atime-change branch 7 times, most recently from d4712c4 to 9505866 Compare November 9, 2018 01:55
@rubennorte rubennorte force-pushed the do-not-trigger-tests-on-atime-change branch 2 times, most recently from fe53472 to df7b3da Compare November 9, 2018 12:10
@rubennorte
Copy link
Contributor Author

I generalized the until helper in runJest to make it easier to interact with the process. With this version it should be easier to test the watch mode (including better tests with multiple interactions).

thymikee
thymikee approved these changes Nov 9, 2018
View reviewed changes
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice!

e2e/__tests__/watch_mode_no_access.test.js Outdated Show resolved Hide resolved
SimenB
SimenB approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome refactor!

e2e/runJest.js Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Jan 14, 2019

@rubennorte land this? 🙂

@SimenB
Copy link
Member

SimenB commented Nov 9, 2019

1 year anniversary - any news @rubennorte? 😀 I can merge in master at least

@SimenB SimenB mentioned this pull request Nov 9, 2019
Merged
@SimenB SimenB force-pushed the do-not-trigger-tests-on-atime-change branch 2 times, most recently from 4d4b2fd to 340d65c Compare November 9, 2019 20:29
@SimenB
Copy link
Member

SimenB commented Nov 9, 2019

I'm unable to make the new test in this PR pass, even using node 8 and being on this very commit... :(

@thymikee thymikee force-pushed the do-not-trigger-tests-on-atime-change branch from 340d65c to 49b5d5d Compare May 3, 2020 19:48
@thymikee thymikee force-pushed the do-not-trigger-tests-on-atime-change branch from 49b5d5d to 54f4418 Compare May 3, 2020 19:49
@thymikee thymikee requested a review from SimenB May 3, 2020 19:51
@thymikee
Copy link
Collaborator

thymikee commented May 3, 2020

Rebased and fixed the test, hope it's ready to go now

@SimenB
Copy link
Member

SimenB commented May 3, 2020 •
edited

@thymikee copyright check failed. Rebase on master for windows fix

@snyk-bot snyk-bot mentioned this pull request Dec 17, 2020
Open
This was referenced Mar 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 6, 2021
Open
Open
Open
Open
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee thymikee approved these changes

@cpojer cpojer cpojer approved these changes

@mjesun mjesun mjesun approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing a file's access time re-runs tests in watch mode
6 participants
@rubennorte @SimenB @thymikee @cpojer @mjesun @facebook-github-bot