fix: do not run global hooks if there are no tests #7745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jan 29, 2019
|
I had the time to push a test before your comment! 😀
|
SimenB
commented
Jan 29, 2019
| '../global-setup/projects.jest.config.js', | ||
| ); | ||
|
|
||
| const result = runWithJson('global-setup', [ |
There was a problem hiding this comment.
runWithJson actually fails without the fix, but I added the assertions either way to assert they don't run, even if we don't crash anymore
thymikee
approved these changes
Jan 29, 2019
This was referenced Jan 29, 2019
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7740.
Also adds a stack trace to that error:
Test plan
Needs to add a test, but I've confirmed it fixes the problem.Test added