fix: make sure generated name in config is stable across runs of Jest
#7746
Conversation
SimenB
force-pushed
the
stable-config-name
branch
from
d94585a
to
86693a2
Compare
|
The failure is what @cpojer mentioned in #5862 (comment). This PR only fixes the scenario with inline projects config. Ergh |
|
:( Lemme see if I can fix it |
|
The test is flaky, passes for me most of the time locally |
|
Pushed a new approach closer to what's in master - it adds the path to the config into the generated name of the project |
| @@ -210,7 +215,7 @@ const groupOptions = ( | |||
| }), | |||
| }); | |||
|
|
|||
| const ensureNoDuplicateConfigs = (parsedConfigs, projects, rootConfigPath) => { | |||
| const ensureNoDuplicateConfigs = (parsedConfigs, projects) => { | |||
There was a problem hiding this comment.
my IDE told me this was an unused arg 🤷♂️
|
Thanks @SimenB ! Really appreciate the help on this. Is there going to be a 24.0.1 release to incorporate this bug fix since I'd rather not pull latest from master ... |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #7732
by basically reverting a change within #5862 (a370c21).Test plan
Restored the tests from the linked commit, and added a new one (minimal config is stable across runs')Added a new test to check two runs of
normalizeare stable, plus an e2e test checking name specifically, both for linked config and inline config