Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore TS type references when looking for out-of-scope references #7799

Merged
merged 1 commit into from Feb 4, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 4, 2019

Summary

Fixes #7798. Essentially the same as #7641.

Test plan

Existing e2e test expanded

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was easier that I thought 😅

@SimenB SimenB merged commit b167892 into jestjs:master Feb 4, 2019
@SimenB SimenB deleted the ts-type-hoist branch February 4, 2019 16:37
@jeysal
Copy link
Contributor

jeysal commented Feb 4, 2019

This was easier that I thought

Exactly how Simen and I felt after #7641, we're running out of people to surprise 😄

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript keywords as out-of-scope variables in jest.mock
4 participants