Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit "only" mode unless there is tests with "only" mode already #7888

Merged
merged 12 commits into from Feb 14, 2019
Merged

Inherit "only" mode unless there is tests with "only" mode already #7888

merged 12 commits into from Feb 14, 2019

Conversation

doniyor2109
Copy link
Contributor

Summary

Fixes #7837

Test plan

yarn test

@doniyor2109
Copy link
Contributor Author

doniyor2109 commented Feb 14, 2019

It is little verbose solution. Welcome to other solutions

@codecov-io
Copy link

Codecov Report

Merging #7888 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7888      +/-   ##
==========================================
- Coverage   58.15%   58.08%   -0.08%     
==========================================
  Files         173      173              
  Lines        6424     6427       +3     
  Branches        5        5              
==========================================
- Hits         3736     3733       -3     
- Misses       2686     2692       +6     
  Partials        2        2
Impacted Files Coverage Δ
packages/jest-circus/src/utils.js 18.48% <ø> (-2.01%) ⬇️
packages/jest-circus/src/eventHandler.js 10.97% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e31173...9429103. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

Left a comment about the integration test, beyond that this lgtm

e2e/__tests__/jestCircus.test.js Outdated Show resolved Hide resolved
packages/jest-circus/src/eventHandler.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this! Left some comments :)

packages/jest-circus/src/eventHandler.js Outdated Show resolved Hide resolved
e2e/Utils.js Outdated Show resolved Hide resolved
doniyor2109 and others added 3 commits February 14, 2019 21:53
Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-circus changes behaviour of it.only inside describe.only
5 participants