TS migration `jest-circus` #7916

doniyor2109 · 2019-02-16T17:06:50Z

Summary

TS migration jest-circus

Test plan

WIP

doniyor2109 · 2019-02-16T17:41:10Z

NodeJS global does not work as I expected 🤔

SimenB

Awesome start!

packages/jest-circus/src/__tests__/circusItTestError.test.ts

packages/jest-circus/src/dts/co.d.ts

packages/jest-circus/src/eventHandler.ts

packages/jest-circus/src/formatNodeAssertErrors.ts

packages/jest-circus/src/types.ts

SimenB · 2019-02-16T17:45:43Z

NodeJS global does not work as I expected 🤔

This doesn't work? https://github.com/facebook/jest/blob/c14a45d89d469c8bf226c5db62bac52d59597a9a/packages/jest-mock/src/index.ts#L10

Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>

doniyor2109 · 2019-02-17T07:32:25Z

#7916 (comment)
This doesn't work?

importing Global type is working but I cannot assign to global type for this case

https://github.com/facebook/jest/blob/d2023f120856314d5c3ca5b2661f894fda471384/packages/jest-circus/src/state.js#L37-L39

doniyor2109 · 2019-02-17T08:15:47Z

importing Global type is working but I cannot assign to global type for this case

jest/packages/jest-circus/src/state.js

Lines 37 to 39 in d2023f1

global[STATE_SYM] = INITIAL_STATE;

It turns out TS does not support keys as symbols yet. There is workaround for it microsoft/TypeScript#24587 (comment). It is not great but it works for now

packages/jest-circus/package.json

packages/jest-circus/src/eventHandler.ts

packages/jest-circus/src/index.ts

packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapter.ts

packages/jest-circus/src/run.ts

packages/jest-circus/src/types.ts

packages/jest-circus/src/utils.ts

codecov-io · 2019-02-17T11:06:38Z

Codecov Report

Merging #7916 into master will increase coverage by 7.09%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master    #7916      +/-   ##
==========================================
+ Coverage   58.32%   65.42%   +7.09%     
==========================================
  Files         164      255      +91     
  Lines        6047     9949    +3902     
  Branches        5     1038    +1033     
==========================================
+ Hits         3527     6509    +2982     
- Misses       2518     3193     +675     
- Partials        2      247     +245

Impacted Files	Coverage Δ
...st-core/src/getNoTestFoundRelatedToChangedFiles.js	`0% <ø> (ø)`
packages/jest-core/src/getNoTestFoundFailed.js	`0% <ø> (ø)`
packages/jest-core/src/TestWatcher.js	`42.85% <ø> (ø)`
packages/jest-cli/src/init/modify_package_json.js	`100% <ø> (ø)`
packages/jest-core/src/ReporterDispatcher.js	`87.5% <ø> (ø)`
packages/jest-core/src/plugins/quit.js	`42.85% <ø> (ø)`
packages/jest-core/src/TestNamePatternPrompt.js	`44.44% <ø> (ø)`
...t-core/src/plugins/update_snapshots_interactive.js	`65.51% <ø> (ø)`
packages/jest-cli/src/init/questions.js	`100% <ø> (ø)`
packages/jest-core/src/TestPathPatternPrompt.js	`46.66% <ø> (ø)`
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14a45d...6401264. Read the comment docs.

Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>

packages/jest-circus/src/types.ts

Exported variable 'jestAdapter' has or is using name '$JestEnvironment' from external module "packages/jest-types/build/Environment" but cannot be named. microsoft/TypeScript#5711

packages/jest-circus/src/__tests__/circusItTestError.test.ts

SimenB · 2019-02-22T13:04:12Z

packages/jest-circus/src/__tests__/hooksError.test.ts


 describe.each([['beforeEach'], ['beforeAll'], ['afterEach'], ['afterAll']])(
  '%s hooks error throwing',
-  fn => {
+  (fn: 'beforeEach' | 'beforeAll' | 'afterEach' | 'afterAll') => {


would be cool to type jest-each so that it would be inferred.

/cc @mattphillips

…rcus/ts_migration

SimenB

Thanks again for a the fantastic work! I've tweaked this a bit (as you probably noticed since we pushed at the same time), and I think this is good to go now. Gonna wait for someone else to review it as well, though 🙂

github-actions · 2021-05-12T00:07:09Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

doniyor2109 added 9 commits February 16, 2019 17:05

Migration to ts (part 1)

1850348

Merge remote-tracking branch 'jest/master' into jest-circus/ts_migration

3309c3b

Migration to ts (part 2)

e89b57b

Migration to ts (part 3)

62d423c

Minor tweaks

6d18743

TS migration (part 4)

f8d6b1c

Wrong dts

a279271

dts for co

d0adc8e

Added project references

bd16585

facebook-github-bot added the cla signed label Feb 16, 2019

doniyor2109 added 2 commits February 16, 2019 22:07

Merge remote-tracking branch 'jest/master' into jest-circus/ts_migration

017df40

Remove not ts module

2ad24c1

SimenB reviewed Feb 16, 2019

View reviewed changes

doniyor2109 and others added 6 commits February 17, 2019 11:56

Replace custom co dts with @types/co

b033e2e

No index file

f75fa0a

Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>

Some tweaks

0fad01d

Some tweaks

e982e1e

Temp DiffOptions type

2d82778

Remove extra eslint disable

c76f342

Workaround for global vars

6401264

SimenB reviewed Feb 17, 2019

View reviewed changes

doniyor2109 and others added 4 commits February 17, 2019 18:04

Resolves

6e11c8d

Move @types/co to devDeps

dd6cc0f

Update packages/jest-circus/src/run.ts

ecdc291

Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>

Update packages/jest-circus/src/utils.ts

54a986e

Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>

doniyor2109 added 3 commits February 22, 2019 10:03

Fix @jest/types cannot be found in test

6df3fd4

Detailed comment for flowfix

bb16143

Ignore ts errors for non migrated modules

9e8545b

SimenB reviewed Feb 22, 2019

View reviewed changes

packages/jest-circus/src/types.ts Outdated Show resolved Hide resolved

doniyor2109 added 3 commits February 22, 2019 14:24

import = is not supported by @babel/plugin-transform-typescript

aa322f8

Fix weired ts error

a0766a6

Exported variable 'jestAdapter' has or is using name '$JestEnvironment' from external module "packages/jest-types/build/Environment" but cannot be named. microsoft/TypeScript#5711

Fix linter errors

1f88dd6

SimenB reviewed Feb 22, 2019

View reviewed changes

packages/jest-circus/src/__tests__/circusItTestError.test.ts Outdated Show resolved Hide resolved

doniyor2109 added 2 commits February 22, 2019 16:16

Remove extra eslint disables

de7b093

Move expect types to @jest/types

ec2bcda

SimenB reviewed Feb 22, 2019

View reviewed changes

SimenB added 2 commits February 22, 2019 14:06

Mgit@github.com:doniyor2109/jest.giterge branch 'master' into jest-ci…

0ed2e9e

…rcus/ts_migration

tweaks

136f986

SimenB requested review from aaronabramov and thymikee February 22, 2019 13:41

SimenB and others added 4 commits February 22, 2019 14:43

remove jest config change

fbe9d77

fix test

5b49c03

Added reminder for replacing Each type

88655bb

keep comments from old tests

849b8c2

SimenB approved these changes Feb 22, 2019

View reviewed changes

SimenB requested review from palmerj3 and mattphillips February 22, 2019 14:10

SimenB changed the title ~~[WIP] TS migration jest-circus~~ TS migration jest-circus Feb 22, 2019

Update CHANGELOG.md

cba5c77

SimenB merged commit e998c92 into jestjs:master Feb 22, 2019

snyk-bot mentioned this pull request Dec 15, 2019

[Snyk] Upgrade babel-jest from 24.0.0 to 24.9.0 jakeherp/burger-builder#14

Open

This was referenced Mar 21, 2020

[Snyk] Upgrade: jest, jest-cli lwojcik/sc2pte-panel-frontend#88

Closed

[Snyk] Upgrade jest from 24.0.0 to 24.9.0 DavidKindler/burger-builder#47

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TS migration `jest-circus` #7916

TS migration `jest-circus` #7916

doniyor2109 commented Feb 16, 2019

doniyor2109 commented Feb 16, 2019

SimenB left a comment

SimenB commented Feb 16, 2019

doniyor2109 commented Feb 17, 2019

doniyor2109 commented Feb 17, 2019 •

edited

codecov-io commented Feb 17, 2019

SimenB Feb 22, 2019

SimenB left a comment

github-actions bot commented May 12, 2021

TS migration jest-circus #7916

TS migration jest-circus #7916

Conversation

doniyor2109 commented Feb 16, 2019

Summary

Test plan

doniyor2109 commented Feb 16, 2019

SimenB left a comment

Choose a reason for hiding this comment

SimenB commented Feb 16, 2019

doniyor2109 commented Feb 17, 2019

doniyor2109 commented Feb 17, 2019 • edited

codecov-io commented Feb 17, 2019

Codecov Report

SimenB Feb 22, 2019

Choose a reason for hiding this comment

SimenB left a comment

Choose a reason for hiding this comment

github-actions bot commented May 12, 2021

TS migration `jest-circus` #7916

TS migration `jest-circus` #7916

doniyor2109 commented Feb 17, 2019 •

edited