Fix transformer signature in babel-jest #7945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
changed the title
rubennorte
commented
Feb 21, 2019
| @@ -47,7 +47,7 @@ | |||
| - `[@jest/transform]`: New package extracted from `jest-runtime` ([#7915](https://github.com/facebook/jest/pull/7915)) | |||
| - `[babel-plugin-jest-hoist]`: Migrate to TypeScript ([#7898](https://github.com/facebook/jest/pull/7898)) | |||
| - `[@jest/core]` Create new package, which is `jest-cli` minus `yargs` and `prompts` ([#7696](https://github.com/facebook/jest/pull/7696)) | |||
| - `[@jest/transform]`: Migrate to TypeScript ([#7918](https://github.com/facebook/jest/pull/7918)) | |||
| - `[@jest/transform]`: Migrate to TypeScript ([#7918](https://github.com/facebook/jest/pull/7918), [#7945](https://github.com/facebook/jest/pull/7945)) | |||
There was a problem hiding this comment.
This bug was introduced there (unpublished) so we don't need to add noise with an extra entry.
mjesun
approved these changes
Feb 21, 2019
|
Possible to add a test that verifies the behavior? |
SimenB
approved these changes
Feb 21, 2019
rubennorte
force-pushed
the
fix-create-transformer-in-babel-jest
branch
2 times, most recently
from
0ece301
to
2e552a3
Compare
rubennorte
force-pushed
the
fix-create-transformer-in-babel-jest
branch
from
2e552a3
to
a913503
Compare
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#7918 changed the transformer signature to include the own
createTransformermethod, which broke due to how it's used by@jest/transform. This only attaches the function to the singleton exported by the package.Fixes https://github.com/facebook/jest/pull/7918/files#r258958414
Test plan
Manually tested internally at FB.
Added an e2e test.