Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup JestEnvironment types #7988

Merged
merged 2 commits into from Feb 26, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 26, 2019

Summary

Played around with it in #7985, and these were the changes I had to make to allow us to do class NodeEnvironment extends JestEnvironment and get proper typings

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #7988 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7988   +/-   ##
=======================================
  Coverage   64.54%   64.54%           
=======================================
  Files         257      257           
  Lines       10076    10076           
  Branches     1586     1587    +1     
=======================================
  Hits         6504     6504           
  Misses       3230     3230           
  Partials      342      342
Impacted Files Coverage Δ
...circus/src/legacy-code-todo-rewrite/jestAdapter.ts 0% <0%> (ø) ⬆️
packages/jest-runner/src/runTest.ts 2.59% <0%> (ø) ⬆️
packages/jest-runtime/src/index.ts 68.98% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419661f...e66b668. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants