[WIP] Migrate jest-repl to typescript #8000
Conversation
| */ | ||
|
|
||
| import Runtime from 'jest-runtime'; | ||
|
|
||
| export const usage = 'Usage: $0 [--config=<pathToConfigFile>]'; | ||
|
|
||
| export const options = { | ||
| ...Runtime.getCLIOptions(), | ||
| export const options = Object.assign({}, Runtime.getCLIOptions(), { |
There was a problem hiding this comment.
Doing this gets a better type.
packages/jest-repl/src/cli/index.ts
Outdated
| const argv = yargs.usage(args.usage).options(args.options).argv; | ||
|
|
||
| validateCLIOptions(argv, {...args.options, deprecationEntries}); | ||
|
|
||
| argv._ = [REPL_SCRIPT]; | ||
|
|
||
| //@ts-ignore Get feedback first in PR |
There was a problem hiding this comment.
The compiler complains that argv has some keys missing. Not sure how to resolve this at the moment.
There was a problem hiding this comment.
Yeah, the argv typing is not really where it should be. this is fine for now 🙂
|
Sure thing about the changelog. Was just opening the PR early to get the ball rolling. |
|
Hmm I think I introduced a regression. All the tests are failing with the same error. hmm 😞 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR migrates jest-repl to typescript.
Notes: