Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing error after test #8005

Merged
merged 4 commits into from Feb 28, 2019
Merged

Fix missing error after test #8005

merged 4 commits into from Feb 28, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 28, 2019

Summary

This is #6794 with a test.

The error isn't pretty, but I think it's fine. Since we're tearing down (and use lazy requires), we might get an error when trying to prettify it

image

Test plan

Green CI

@@ -230,6 +246,9 @@ export const callAsyncCircusFn = (
timeoutID.unref && timeoutID.unref();
clearTimeout(timeoutID);
throw error;
})
.finally(() => {
completed = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too happy about this, but we don't have access to the test definition, and the promise has already been resolved. Might make sense to dispatch some "suite failed" event or something like that?

@aaronabramov thoughts?

@SimenB
Copy link
Member Author

SimenB commented Feb 28, 2019

bah, node 6 and 8 doesn't have finally

@SimenB SimenB merged commit 591eb99 into jestjs:master Feb 28, 2019
@SimenB SimenB deleted the error-after-test branch February 28, 2019 18:09
elenap1991 added a commit to elenap1991/external-courses that referenced this pull request May 26, 2019
due to jest fix jestjs/jest#8005
After this update travis would output real errors of css validation tests
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants