Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-each] refactor into multiple files with better types #8018

Merged
merged 16 commits into from Mar 2, 2019

Conversation

mattphillips
Copy link
Contributor

@mattphillips mattphillips commented Mar 1, 2019

Summary

This PR refactors jest-each to make it more modular and have better type definitions both of which I am hoping will make it easier to maintain.

Test plan

All existing tests (unit and e2e) should still pass.

@mattphillips mattphillips changed the title Jest each rewrite [jest-each] refactor into multiple files with better types Mar 1, 2019
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hell yeah, this is fantastic!

packages/jest-each/src/bind.ts Outdated Show resolved Hide resolved
packages/jest-each/src/validation.ts Outdated Show resolved Hide resolved
SimenB and others added 3 commits March 1, 2019 23:30
Co-Authored-By: mattphillips <matt@mattphillips.io>
Co-Authored-By: mattphillips <matt@mattphillips.io>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants