Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export DiffOptions from jest-diff #8027

Merged
merged 2 commits into from Mar 3, 2019
Merged

chore: export DiffOptions from jest-diff #8027

merged 2 commits into from Mar 3, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 3, 2019

Summary

We want to export DiffOptions from jest-diff so it can be used as a parameter at usage sites

Test plan

Green CI

jeysal
jeysal approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, always good to remove references/devDeps.
Kind of unfortunate that DiffOptions is part of the jest-matcher-utils interface now, but dunno if I could have done the whole shouldPrintDiff thing differently with reasonable effort.

@SimenB SimenB merged commit 4c25942 into jestjs:master Mar 3, 2019
@SimenB SimenB deleted the diff-options-export branch March 3, 2019 13:31
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Mar 21, 2020
Closed
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimenB @jeysal @facebook-github-bot