Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create new @jest/console package #8030

Merged
merged 1 commit into from Mar 3, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 3, 2019

Summary

Keep cutting away at jest-util. First commit is from #8029, ignore it.

Test plan

Green CI

@SimenB SimenB changed the title Jest console chore: create new @jest/console package Mar 3, 2019
@SimenB SimenB force-pushed the jest-console branch 2 times, most recently from 8256295 to e17c919 Compare March 3, 2019 16:10
@codecov-io
Copy link

Codecov Report

Merging #8030 into master will decrease coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8030      +/-   ##
=========================================
- Coverage   63.31%   63.3%   -0.02%     
=========================================
  Files         263     263              
  Lines       10266   10268       +2     
  Branches     2098    2100       +2     
=========================================
  Hits         6500    6500              
- Misses       3273    3275       +2     
  Partials      493     493
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 68.98% <ø> (ø) ⬆️
packages/jest-source-map/src/getCallsite.ts 75% <ø> (ø)
packages/jest-console/src/getConsoleOutput.ts 0% <ø> (ø)
packages/jest-runner/src/runTest.ts 2.53% <0%> (ø) ⬆️
packages/jest-console/src/BufferedConsole.ts 70% <100%> (ø)
packages/jest-core/src/runJest.ts 33.78% <33.33%> (ø) ⬆️
packages/jest-console/src/CustomConsole.ts 68.75% <50%> (ø)
packages/jest-util/src/clearLine.ts 0% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c25942...110da28. Read the comment docs.

@SimenB SimenB requested a review from thymikee March 3, 2019 17:50
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

config: Config.ProjectConfig,
) {
// @ts-ignore: `_log` is `private` - we should figure out some proper API here
testConsole._log = function fakeConsolePush(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a nice followup to have a setter for that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, some sort of "disable logging" would be nice. We inject the instance into the sandbox though, so probably hide it behind a Symbol or something

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants