Fix retries and error notification in workers #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
requested review from
mjesun,
SimenB and
rickhanlonii
and removed request for
mjesun
mjesun
approved these changes
Mar 7, 2019
rubennorte
changed the title
rubennorte
changed the title
SimenB
approved these changes
Mar 7, 2019
thymikee
approved these changes
Mar 7, 2019
rubennorte
force-pushed
the
worker-fatal-errors
branch
from
992d9ab
to
10f7a4e
Compare
rubennorte
force-pushed
the
worker-fatal-errors
branch
from
10f7a4e
to
f5f2ed6
Compare
rubennorte
force-pushed
the
worker-fatal-errors
branch
from
70e173a
to
df62dd6
Compare
rubennorte
force-pushed
the
worker-fatal-errors
branch
from
03723d6
to
6cee8b2
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handling of errors in workers in
jest-workerworker is broken which causes several observable issues:Test plan
Added unit tests for the workers to make sure messages are re-send to the workers after they're initialized, and an e2e test that makes sure we handle fatal errors in tests properly.