fix: jest-worker can return null
for getStdout()
#8083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A
null
check was added in #8045 (comment). However, it most certainly can benull
, and the type definition forWorkerInterface
was wrong.jest-runner
even guards against it: https://github.com/facebook/jest/blob/1fd565168dbf5b49780df959a214148eb35d32db/packages/jest-runner/src/index.ts#L113-L114Fixes #8078
Test plan
Not really a testable change since the unit tests mock out
child_process.fork
. However, the type is now corrected.