chore: copy d.ts files during build #8086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, this won't work as I think we need to have those |
This reverts commit 5d2c2e7.
thymikee
approved these changes
Mar 8, 2019
|
It'll be good to ditch them entirely |
|
@SimenB Thanks! Would it be possible to get a release with this soon so TS users can use jest 24.3 without running into compilation errors? |
|
Yeah, there'll probably be a release on monday |
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8085
Test plan
I've verified the files are in thebuilddir after runningscripts/buildTs.jsI've verified that VS Code is able to follow the link in the built file and that the files are included by
yarn pack