Update --forceExit and "did not exit for one second" message colors. #8329
+11
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Apr 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #8329 +/- ##
=======================================
Coverage 62.17% 62.17%
=======================================
Files 266 266
Lines 10694 10694
Branches 2602 2603 +1
=======================================
Hits 6649 6649
Misses 3459 3459
Partials 586 586Continue to review full report at Codecov.
|
SimenB
approved these changes
Apr 14, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
--forceExitwarning is misleading because it's a bold, red message for something that you've specifically opted in to. When I run tests, my eye is looking for red to show me that something failed. If my project needs to use--forceExit, I shouldn't see red every single time. Red should be reserved for errors.I've updated the message. It's now on one line and white. It's something you will see every single run, it shouldn't draw your eye too much.
Similarly, the "Jest did not exit for one second" message is currently shown in red. This message shouldn't show every time and should catch the user's eye. However, it's not an error by itself, it's a warning. It's possible that the test run completes successfully after this message is printed. I've updated the color to match.
Test plan