Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting function name for rare cases #8362

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Connormiha
Copy link
Contributor

Summary

Helper for getting function name in some cases returns wrong function name.
For example: If we somehow lost the property name in function, then we used regExp that failed with async function, function generator and function with $ in name.
One more rare case if toString method was changed.

Test plan

I added tests for these cases

@codecov-io
Copy link

Codecov Report

Merging #8362 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8362      +/-   ##
==========================================
+ Coverage   62.27%   62.29%   +0.02%     
==========================================
  Files         266      266              
  Lines       10728    10729       +1     
  Branches     2609     2608       -1     
==========================================
+ Hits         6681     6684       +3     
+ Misses       3462     3460       -2     
  Partials      585      585
Impacted Files Coverage Δ
packages/expect/src/jasmineUtils.ts 91.22% <100%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1e3f8...c2eaf62. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants