Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual mocks not being unmockable after previously being mocked #8396

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Blasz
Copy link
Contributor

@Blasz Blasz commented Apr 30, 2019

Summary

Fixes #8395 where virtual mocks could not be unmocked after previously being mocked.

Test plan

Repro steps are in a test case and now pass.

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #8396 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8396      +/-   ##
==========================================
- Coverage   62.34%   62.33%   -0.02%     
==========================================
  Files         266      266              
  Lines       10738    10735       -3     
  Branches     2612     2610       -2     
==========================================
- Hits         6695     6692       -3     
  Misses       3460     3460              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 69.39% <ø> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b8382...5510a91. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual mocks cannot be unmocked
5 participants