fix: absolute path moduleNameMapper + jest.mock issue #8727
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
chauchakching
force-pushed
the
master
branch
2 times, most recently
from
ccfecbe
to
e6af696
Compare
|
Any news here? It seems sane to me, and tests are passing. Rebasing on master should fix the CI failure on circus |
|
@chauchakching ping 🙂. Is it ready to be out of Draft now? |
chauchakching
force-pushed
the
master
branch
2 times, most recently
from
8bb7673
to
9bf438d
Compare
|
Almost forgot I had this PR... |
|
Thanks @chauchakching! It seems tests are failing on CI, would you be able to take a look? |
of course |
|
2 hg tests failed on my mac though, even on master branch |
|
Yeah, ignore the mercurial tests, they only work on very specific versions of mercurial |
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
In this special case, the moduleNameMapper got applied to the import path twice, resulting in an invalid module path.
still validating the changes, WIP
Fixes #8633
Test plan
Added the absolute path moduleNameMapper test case.