getTimerCount will not include cancelled immediates #8764
Conversation
|
Should cancelled immediates get removed so |
|
Looking through the usages, I didn't see a reason why there kept around yeah. |
| // Callback may throw, so update the map prior calling. | ||
| cancelledImmediates[String(uuid)] = true; | ||
| callback.apply(null, args); | ||
| if (immediates.find(x => x.uuid === uuid)) { |
There was a problem hiding this comment.
please refer to this comment: #8764 (comment)
There was a problem hiding this comment.
I mean, why do we have find at all?
There was a problem hiding this comment.
so we don't run immediates more than once.
If it was cleared (not in the immediates array) then it shouldn't run even if runAllImmediates is called
|
The CI test that fails is not using fake timers, so not sure why it's red. Will investigate... |
|
CI is failing, though 😢 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
In our projects we check
getTimerCount()to know that all our timers/immediates are cleaned between tests.I noticed that the number is getting larger after each test.
It seems that
getTimerCount()counts cancelled immediates, this PR fixes this.Test plan
added a test at
jestFakeTimers.test.ts