fix: Jest multi project runner still cannot handle exactly one project #8894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrick95
commented
Sep 5, 2019
kenrick95
commented
Sep 5, 2019
kenrick95
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8894 +/- ##
=========================================
+ Coverage 65.09% 65.1% +0.01%
=========================================
Files 278 278
Lines 11860 11860
Branches 2922 2922
=========================================
+ Hits 7720 7722 +2
Misses 3511 3511
+ Partials 629 627 -2
Continue to review full report at Codecov.
|
SimenB
reviewed
Nov 9, 2019
|
Sorry about the late feedback... Would you be able to rebase, just so we are sure it still passes CI? |
|
Sure no problem 😁 |
thymikee
reviewed
Nov 11, 2019
thymikee
approved these changes
Nov 22, 2019
SimenB
reviewed
Nov 22, 2019
kenrick95
changed the title
Add failing test case Explicitly distinguish if project has been added using process.cwd Fix CI errors Add back old test Apply solution without isGlobalProject Apply suggestion from code review Add changelog
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 11, 2020
This was referenced Feb 25, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a failing test case for #8860
but I haven't had any clue on how to fix itand I found a way to solve it, but I actually wonder if this is the best way to fix this. I guess I need input from the maintainers.There are failing tests when I do the following change
The main issue was that at
readConfigs, when callingreadConfig,skipArgvConfigOptionshould only betrueif the project is not "global". By global, I mean, it is not added fromgetProjectListFromCLIArgsusingprocess.cwd. That's why I changedgetProjectListFromCLIArgsto also returnisGlobalProject.Update: the implementation have changed based on suggestion during code review: #8894 (comment)
Test plan
Added unit test case :)